Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[breaking/do not merge] es(1403): improve middleware extension hooks configuration types #7372

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lsliwaradioluz
Copy link
Collaborator

@lsliwaradioluz lsliwaradioluz commented Jan 16, 2025

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 3db4445

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vue-storefront/multistore Patch
@vue-storefront/middleware Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lsliwaradioluz lsliwaradioluz changed the title es(1403): improve middleware extension hooks configuration types [breaking/do not merge] es(1403): improve middleware extension hooks configuration types Jan 16, 2025
@lsliwaradioluz lsliwaradioluz marked this pull request as ready for review January 16, 2025 14:03
@lsliwaradioluz lsliwaradioluz requested a review from a team as a code owner January 16, 2025 14:03
@fumeoss
Copy link

fumeoss commented Feb 20, 2025

Summary

  • Introduces breaking changes to the @vue-storefront/middleware package regarding middleware extension hooks configuration types.
  • Updates the type of the hooks property in the ApiClientExtension interface to ensure proper typing of the hooks' configuration parameter.
  • Changes the return type of the createMultistoreExtension helper to ApiClientExtension.
  • Both changes require consumers of the middleware to update if they are using version 4.1.2 or lower.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants