Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[breaking/do not merge] es(1403): improve middleware extension hooks configuration types #7372

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+14 −4
Open

[breaking/do not merge] es(1403): improve middleware extension hooks configuration types #7372

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d62412
feat: pass generic config type down to hooks
lsliwaradioluz Jan 16, 2025
82421b5
feat: define return type of createMultistoreExtension helper
lsliwaradioluz Jan 16, 2025
b3a8a20
chore: middleware changeset
lsliwaradioluz Jan 16, 2025
8886bfe
chore: multistore changeset
lsliwaradioluz Jan 16, 2025
c6fbba9
chore: remove satisfies from createMultistoreExtension
lsliwaradioluz Jan 16, 2025
3db4445
chore: mention reason for breaking change
lsliwaradioluz Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: pass generic config type down to hooks
  • Loading branch information
@lsliwaradioluz
lsliwaradioluz committed Jan 16, 2025
commit 5d624124cb1983adb511e633ac0629c977bdf602
4 changes: 2 additions & 2 deletions packages/middleware/src/types/common.ts
View file
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@ export interface ApiClientExtension<API = any, CONTEXT = any, CONFIG = any> {
req: AlokaiRequest,
res: AlokaiResponse,
hooksContext: AlokaiContainer
) => ApiClientExtensionHooks;
) => ApiClientExtensionHooks<CONFIG>;
}

export type ErrorHandler = (
@@ -129,7 +129,7 @@ export interface Integration<
extensions: ApiClientExtension<API, CONTEXT>[]
// TODO(IN-4338): There is a bug in the types here
// we're not able to verify if the methods are namespaced or not with this implementation.
) => ApiClientExtension<API, CONTEXT>[];
) => ApiClientExtension<API, CONTEXT, CONFIG>[];
customQueries?: Record<string, CustomQueryFunction>;
initConfig?: TObject;
/**