feat: Authenticate private resource requests #21331

dcalhoun · 2024-10-23T00:42:53Z

Description

Authenticate resource requests originating from within the WebView so that
requests to private sites succeed.

To Test:

See wordpress-mobile/GutenbergKit#34.

Regression Notes

Potential unintended areas of impact
Gutenberg Mobile or Aztec editors fail.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested both editors.
What automated tests I added (or what prevented me from doing so)
None, feels unnecessary for this currently experimental editor feature.

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic · 2024-10-23T00:46:49Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2024-10-23T00:50:51Z

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list

Upgraded Dependencies
org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596, (changed from trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33)

tree

 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33
+|    \--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596
-\--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596 (*)

wpmobilebot · 2024-10-23T01:03:03Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21331-fc246b1
	Commit	`fc246b1`
	Direct Download	`wordpress-prototype-build-pr21331-fc246b1.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-10-23T01:03:05Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21331-fc246b1
	Commit	`fc246b1`
	Direct Download	`jetpack-prototype-build-pr21331-fc246b1.apk`

Note: Google Login is not supported on these builds.

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

dcalhoun · 2024-10-30T15:49:42Z

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

+
+        String proxyUrl = url.toString();
+        if (mIsPrivateAtomic) {
+            proxyUrl = getPrivateResourceProxyUrl(url);


Private Atomic sites require a proxy for request authentication (D38925-code).

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

Address lint error regarding a common source of bugs. #21331 (review)

sonarqubecloud · 2024-11-01T13:56:44Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dcalhoun · 2024-11-01T14:00:36Z

👋🏻 @jkmassel. I updated this with the merged wordpress-mobile/GutenbergKit#30 and the latest from trunk. I re-tested and it appears to be functioning as expected. Whenever you have time, we can look to review and merge this feature. Thanks!

nbradbury · 2025-02-18T12:43:13Z

@dcalhoun @jkmassel Where do we stand with this PR? Is it something we can close?

dcalhoun · 2025-02-18T12:47:52Z

Where do we stand with this PR? Is it something we can close?

Ideally, it is merged.

However, @jkmassel mentioned privately he would prefer avoiding a proxy URL. Transparently, I was unsure as to how we might accomplish that, so I have not moved this forward. @jkmassel do you have specific ideas for avoiding the proxy URL?

Unauthenticated requests fail when attempting to load resources from a private site--e.g., an image.

Avoid NullPointerExceptions.

sonarqubecloud · 2025-02-19T16:43:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-02-19T17:02:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.41%. Comparing base (191c357) to head (fc246b1).

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #21331   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files        2122     2122           
  Lines       99570    99570           
  Branches    15324    15324           
=======================================
  Hits        39247    39247           
  Misses      56844    56844           
  Partials     3479     3479

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dcalhoun added [Type] Bug Gutenberg Editing and display of Gutenberg blocks. labels Oct 23, 2024

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Fixed Show fixed Hide fixed

dcalhoun mentioned this pull request Oct 24, 2024

fix: Rely upon the WebView for completing non-intercepted requests wordpress-mobile/GutenbergKit#34

Merged

dcalhoun commented Oct 30, 2024

View reviewed changes

dcalhoun marked this pull request as ready for review October 30, 2024 16:08

dcalhoun requested a review from jkmassel October 30, 2024 16:08

jkmassel reviewed Oct 30, 2024

View reviewed changes

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Outdated Show resolved Hide resolved

dcalhoun requested a review from jkmassel October 30, 2024 20:25

github-advanced-security bot found potential problems Oct 30, 2024

View reviewed changes

libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Fixed Show fixed Hide fixed

dcalhoun added a commit that referenced this pull request Oct 31, 2024

fix: Avoid implicit use of default locale

9c41ed3

Address lint error regarding a common source of bugs. #21331 (review)

dcalhoun added 2 commits February 19, 2025 09:39

feat: Authenticate private resource requests

474c919

Unauthenticated requests fail when attempting to load resources from a private site--e.g., an image.

style: Address lint warnings

fc246b1

Avoid NullPointerExceptions.

dcalhoun force-pushed the feat/authenticate-private-resource-requests branch from 172e55e to fc246b1 Compare February 19, 2025 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Authenticate private resource requests #21331

feat: Authenticate private resource requests #21331

dcalhoun commented Oct 23, 2024 •

edited

Loading

dangermattic commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading

dcalhoun Oct 30, 2024

sonarqubecloud bot commented Nov 1, 2024

dcalhoun commented Nov 1, 2024

nbradbury commented Feb 18, 2025

dcalhoun commented Feb 18, 2025

sonarqubecloud bot commented Feb 19, 2025

codecov bot commented Feb 19, 2025

feat: Authenticate private resource requests #21331

Are you sure you want to change the base?

feat: Authenticate private resource requests #21331

Conversation

dcalhoun commented Oct 23, 2024 • edited Loading

Related

Description

To Test:

Regression Notes

PR Submission Checklist:

Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented Oct 23, 2024 • edited Loading

wpmobilebot commented Oct 23, 2024 • edited Loading

Project dependencies changes

wpmobilebot commented Oct 23, 2024 • edited Loading

wpmobilebot commented Oct 23, 2024 • edited Loading

dcalhoun Oct 30, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed

dcalhoun commented Nov 1, 2024

nbradbury commented Feb 18, 2025

dcalhoun commented Feb 18, 2025

sonarqubecloud bot commented Feb 19, 2025

Quality Gate passed

codecov bot commented Feb 19, 2025

Codecov Report

dcalhoun commented Oct 23, 2024 •

edited

Loading

dangermattic commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading

wpmobilebot commented Oct 23, 2024 •

edited

Loading