Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Various pessimistic proofs fixes and adaption to kurtosis-cdk pessimistic proof branch #165

Merged
merged 27 commits into from
Nov 8, 2024

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Nov 6, 2024

Description

This PR includes:

  1. Fix for replacing InError certificates. When a certificate is marked as InError on agglayer, we need to build a new one with the same height, that includes its bridges and claims, plus new ones that we saw in the meantime.
  2. Fix for checking if Candidate and Proven certificates were also settled on the agglayer, because we cannot send a new one, until the previous one is either marked as InError or Settled.
  3. Adapting local_config script to the new kurtosis-cdk version.
  4. Fix where aggsender sent nil for imported bridge exits when it doesnt have any claims.
  5. Fix where we didn't rollback db transaction in the the aggsender_storage.
  6. Change db to store hashes as text
  7. Add logs

Config changes

Parameter SaveCertificatesToFiles (bool) have been changed by SaveCertificatesToFilesPath: if is = "" is disabled, if not it write certificated in the specific path

[aggsender]
SaveCertificatesToFilesPath = ""

@goran-ethernal goran-ethernal force-pushed the feature/adapt_kurtosis_pp branch from 434abbd to 73dfe95 Compare November 6, 2024 16:20
@goran-ethernal goran-ethernal force-pushed the feature/adapt_kurtosis_pp branch from 5242ecf to 70aaaaf Compare November 7, 2024 10:27
@goran-ethernal goran-ethernal marked this pull request as ready for review November 7, 2024 12:08
@goran-ethernal goran-ethernal force-pushed the feature/adapt_kurtosis_pp branch from f4338f1 to e2ff575 Compare November 7, 2024 13:59
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
G
T
M

Copy link

sonarqubecloud bot commented Nov 8, 2024

@goran-ethernal goran-ethernal merged commit d4cf2db into develop Nov 8, 2024
10 checks passed
@goran-ethernal goran-ethernal deleted the feature/adapt_kurtosis_pp branch November 8, 2024 13:27
Vui-Chee added a commit to okx/xlayer-cdk that referenced this pull request Nov 20, 2024
* dev: (30 commits)
  Delete build rust bin file
  test: fix v0.4.0 beta10 fix ut (#6)
  fix: aggregating proofs (0xPolygon#191)
  feat: improve aggsender logs (0xPolygon#186)
  fix: ut
  fix: add new error
  feat: include aggsender to release 0.4.0 (0xPolygon#181)
  feat: remove sanity check (0xPolygon#178)
  feat: sync UpdateL1InfoTreeV2 (0xPolygon#145)
  fix:  local configuration bumping kurtosis to 0.2.29 (0xPolygon#176)
  chore: bump kustoris (0xPolygon#168)
  feat: add timestamps to certificate (0xPolygon#175)
  fix: Various pessimistic proofs fixes and adaption to `kurtosis-cdk`  pessimistic proof branch (0xPolygon#165)
  feat: align Develop with changes in Release/0.4.0 (0xPolygon#174)
  feat: sqlite reorgdetector (0xPolygon#160)
  feat: Use ListOffChainData instead of GetOffChainData (0xPolygon#152)
  bump versions
  Reapply "chore: bump cdk-erigon to v2.1.2" (0xPolygon#162)
  apply feedback
  hotfix: bad merge
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants