-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Various pessimistic proofs fixes and adaption to kurtosis-cdk
pessimistic proof branch
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
434abbd
to
73dfe95
Compare
5242ecf
to
70aaaaf
Compare
joanestebanr
reviewed
Nov 7, 2024
f4338f1
to
e2ff575
Compare
joanestebanr
approved these changes
Nov 7, 2024
Stefan-Ethernal
approved these changes
Nov 8, 2024
vcastellm
reviewed
Nov 8, 2024
vcastellm
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
G
T
M
|
Vui-Chee
added a commit
to okx/xlayer-cdk
that referenced
this pull request
Nov 20, 2024
* dev: (30 commits) Delete build rust bin file test: fix v0.4.0 beta10 fix ut (#6) fix: aggregating proofs (0xPolygon#191) feat: improve aggsender logs (0xPolygon#186) fix: ut fix: add new error feat: include aggsender to release 0.4.0 (0xPolygon#181) feat: remove sanity check (0xPolygon#178) feat: sync UpdateL1InfoTreeV2 (0xPolygon#145) fix: local configuration bumping kurtosis to 0.2.29 (0xPolygon#176) chore: bump kustoris (0xPolygon#168) feat: add timestamps to certificate (0xPolygon#175) fix: Various pessimistic proofs fixes and adaption to `kurtosis-cdk` pessimistic proof branch (0xPolygon#165) feat: align Develop with changes in Release/0.4.0 (0xPolygon#174) feat: sqlite reorgdetector (0xPolygon#160) feat: Use ListOffChainData instead of GetOffChainData (0xPolygon#152) bump versions Reapply "chore: bump cdk-erigon to v2.1.2" (0xPolygon#162) apply feedback hotfix: bad merge ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
InError
certificates. When a certificate is marked asInError
onagglayer
, we need to build a new one with the same height, that includes its bridges and claims, plus new ones that we saw in the meantime.Candidate
andProven
certificates were also settled on theagglayer
, because we cannot send a new one, until the previous one is either marked asInError
orSettled
.local_config
script to the newkurtosis-cdk
version.db
transaction in the theaggsender_storage
.Config changes
Parameter
SaveCertificatesToFiles
(bool) have been changed bySaveCertificatesToFilesPath
: if is = "" is disabled, if not it write certificated in the specific path