feat: aggsender e2e #183
feat: aggsender e2e #183
Conversation
joanestebanr
force-pushed
the
feature/aggsender-e2e
branch
from
76e10de to
dc75fe3
Compare
There was a problem hiding this comment.
Folder naming is inconsistent: fep vs pessimistic it should be pp + fep or pessimistic + full-execution or another option but consistent
Aside from that, to really be an e2e test, it should work the same way a user would do, querying the DB is something not realistic for the user. To check the certificates we should query the AggLayer using getCertificateHeader RPC
or getLatestKnownCertificateHeader that should be enough to know that the certificate was sent correctly.
Ok, I wil change pessimistic to pp
The test, as I explained, is a minium version and not ideal, for sure. The end-point required to retrieve a certificate is not released yet ( check issue) , so the best approach is check on DB |
There was a problem hiding this comment.
The test, as I explained, is a minium version and not ideal, for sure. The end-point required to retrieve a certificate is not released yet ( check issue) , so the best approach is check on DB
I understand the situation, without those endpoints I agree checking the DB is the best way to check for certs, but the endpoints are released in 0.2.0-RC as I checked with the team, it should work with the image in this PR, the issue was closed a few mins ago, so let's not introduce more short-time debt here and work with what the agglayer have, no?
We have another PR to integrating this new end-point, so it make sense to merge this one as-is and in the new PR update the |
|
* tag 'v0.5.0-beta6': feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208) feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209) chore: simplify the `HashMeddler` (0xPolygon#205) fix: clean proof table on start (0xPolygon#207) (0xPolygon#210) feat: improve logs (0xPolygon#204) fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199) fix: Integration Bali PP (0xPolygon#198) feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192) feat: sqlite aggregator (0xPolygon#189) feat: BridgeMessage e2e test (0xPolygon#184) feat: aggsender e2e (0xPolygon#183) fix: aggregating proofs (0xPolygon#191) (0xPolygon#193) feat: l1infotreesync can be run as individual component (0xPolygon#188) fix: l1infotree flaky test (0xPolygon#182) fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185) feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187) feat: remove sanity check (0xPolygon#178) (0xPolygon#179) refact: GetSequence method (0xPolygon#169) feat: epoch notifier (0xPolygon#144) feat: unpack and log agglayer errors (0xPolygon#158)
* dev: (22 commits) fix issues feat: healthcheck (#11) feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208) feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209) chore: simplify the `HashMeddler` (0xPolygon#205) fix: clean proof table on start (0xPolygon#207) (0xPolygon#210) feat: improve logs (0xPolygon#204) fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199) fix: Integration Bali PP (0xPolygon#198) feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192) feat: sqlite aggregator (0xPolygon#189) feat: BridgeMessage e2e test (0xPolygon#184) feat: aggsender e2e (0xPolygon#183) fix: aggregating proofs (0xPolygon#191) (0xPolygon#193) feat: l1infotreesync can be run as individual component (0xPolygon#188) fix: l1infotree flaky test (0xPolygon#182) fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185) feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187) feat: remove sanity check (0xPolygon#178) (0xPolygon#179) refact: GetSequence method (0xPolygon#169) ...
Description
aggsenderdatabase if there are 1 settle certificate