fix: 修复函数库,非必填引用类型,不传值 执行报错 #1564 #1570
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -62,6 +62,8 @@ def valid_reference_value(_type, value, name): | |||
| def convert_value(name: str, value, _type, is_required, source, node): | |||
| if not is_required and value is None: | |||
| return None | |||
| if not is_required and source == 'reference' and (value is None or len(value) == 0): | |||
| return None | |||
| if source == 'reference': | |||
| value = node.workflow_manage.get_reference_field( | |||
| value[0], | |||
There was a problem hiding this comment.
这个函数的目的是将名称和值转换为不同的形式，并在必要的情况下进行处理。
我发现了两个问题：
- 在
if source == 'reference':语句中添加了多余的括号，应该变为(source == 'reference'). - 如果值为空列表（即源引用的内容是空），则应返回None，没有改变其他情况下的逻辑。
len(value)和- 1之间的连接使用错误：应用Python规则"数字与操作符之间必须有空白字符或一个逗号."
修复后的版本如下所示:
def convert_value(name: str, value, _type, is_required, source, node):
if not is_required and value is None:
return None
elif source == "reference":
# 这里需要根据具体情况进行修改以匹配实际需求
else:
raise ValueError("Invalid parameter values")这解决了原始代码中的这些问题并提高了正确性。此外，现在可以在每个具体的场景下执行特定的操作来实现所需的行为，而不仅仅是通过单一条件覆盖所有可能性。希望这是您所寻求的答案！
fix: 修复函数库,非必填引用类型,不传值 执行报错 #1564