Revert "Make the SIOFrameWriter call to finish non-mandatory (#446)"

This reverts commit 6409d58.
AIDASoft · Jul 13, 2023 · 636ba78 · 636ba78
1 parent 6409d58
commit 636ba78
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/include/podio/SIOFrameWriter.h b/include/podio/SIOFrameWriter.h
@@ -17,7 +17,7 @@ class Frame;
 class SIOFrameWriter {
 public:
   SIOFrameWriter(const std::string& filename);
-  ~SIOFrameWriter();
+  ~SIOFrameWriter() = default;
 
   SIOFrameWriter(const SIOFrameWriter&) = delete;
   SIOFrameWriter& operator=(const SIOFrameWriter&) = delete;
@@ -37,7 +37,6 @@ class SIOFrameWriter {
   sio::ofstream m_stream{};       ///< The output file stream
   SIOFileTOCRecord m_tocRecord{}; ///< The "table of contents" of the written file
   DatamodelDefinitionCollector m_datamodelCollector{};
-  bool m_finished{false}; ///< Has finish been called already?
 };
 } // namespace podio
 

diff --git a/src/SIOFrameWriter.cc b/src/SIOFrameWriter.cc
@@ -26,12 +26,6 @@ SIOFrameWriter::SIOFrameWriter(const std::string& filename) {
   sio_utils::writeRecord(blocks, "podio_header_info", m_stream, sizeof(podio::version::Version), false);
 }
 
-SIOFrameWriter::~SIOFrameWriter() {
-  if (!m_finished) {
-    finish();
-  }
-}
-
 void SIOFrameWriter::writeFrame(const podio::Frame& frame, const std::string& category) {
   writeFrame(frame, category, frame.getAvailableCollections());
 }