Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make the SIOFrameWriter call to finish non-mandatory #446

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Make the SIOFrameWriter call to finish non-mandatory #446

merged 1 commit into from
Jul 13, 2023

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

ENDRELEASENOTES

@hegner hegner merged commit 6409d58 into AIDASoft:master Jul 13, 2023
@tmadlener tmadlener mentioned this pull request Jul 13, 2023
Merged
4 tasks
tmadlener added a commit that referenced this pull request Jul 13, 2023
@tmadlener
Revert "Make the SIOFrameWriter call to finish non-mandatory (#446)"
636ba78 
This reverts commit 6409d58.
@tmadlener
Copy link
Collaborator Author

Could we wait for CI to finish before merging, regardless of how trivial the PR looks, please? This one was missing 654ad98 (I pushed that to master directly now)

hegner pushed a commit to hegner/podio that referenced this pull request Jul 27, 2023
@tmadlener @hegner
Make the SIOFrameWriter call to finish non-mandatory (AIDASoft#446)
0f393f2
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmcarcell jmcarcell jmcarcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmadlener @jmcarcell @hegner