Improve Data Library incremental build #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for better incremental developer workflow by tracking files that have changed.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Feb 15, 2025
jstone-lucasfilm
merged commit 9fa52ca
into
AcademySoftwareFoundation:main
34 checks passed
This was referenced Feb 17, 2025
jstone-lucasfilm
added a commit
to jstone-lucasfilm/MaterialX
that referenced
this pull request
Feb 20, 2025
…tion#2226)" This reverts commit 9fa52ca.
jstone-lucasfilm
pushed a commit
that referenced
this pull request
Feb 26, 2025
When working on #2226 I inadvertently introduce the use of `copy_directory_if_different` which doesn't exist until CMake 3.26.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how cmake handles the data library files. Previously they were just being copied during the INSTALL stage, which meant that incremental updates would not always accurately be respected. This PR changes that to BUILD the data library files and then install that built folder when requested.