Update CMake minimum version to 3.26 #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me, thanks @ld-kerley, though I'd like to bring this up on the MaterialX Slack just to double-check that teams are OK with the change.
jstone-lucasfilm
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
This change looks good to me, @ld-kerley, and we have confirmation from our OpenUSD colleagues that it works for them as well.
jstone-lucasfilm
merged commit 4f7d041
into
AcademySoftwareFoundation:main
34 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #2226 I inadvertently introduce the use of
copy_directory_if_differentwhich doesn't exist until CMake 3.26. An alternate implementation failed the Windows CI - so bumping the minimum version seems like the easiest path forwards.