Merge pull request #168 from Alexhuszagh/valgrind

Use an older nightly toolchain to fix spurious memleak issues.
Alexhuszagh · Oct 4, 2024 · 4176535 · 4176535
2 parents 5165ad7 + 134335d
commit 4176535
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/.github/workflows/Valgrind.yml b/.github/workflows/Valgrind.yml
@@ -14,9 +14,14 @@ jobs:
       - name: Install latest nightly
         uses: dtolnay/rust-toolchain@stable
         with:
-            toolchain: nightly
+            # NOTE: For whatever reason, there's a memory leak for recent
+            # versions if we don't FULLY qualify the toolchain version.
+            # This seems to have happened between 2024-09-27 and 2024-10-03.
+            # But, since it requires an unqualified nightly name, it's
+            # impossible to bisect.
+            toolchain: nightly-2024-09-27
       - run: sudo apt-get update
       - run: sudo apt-get install valgrind
-      - run: cargo +nightly install cargo-valgrind
-      - run: cargo +nightly valgrind test --release
-      - run: cargo +nightly valgrind test --all-features --release
+      - run: cargo +nightly-2024-09-27 install cargo-valgrind
+      - run: cargo +nightly-2024-09-27 valgrind test --release
+      - run: cargo +nightly-2024-09-27 valgrind test --all-features --release