Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use an older nightly toolchain to fix spurious memleak issues. #168

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Alexhuszagh
Copy link
Owner

After the test cleanup, the test result is ok with no memory leaks in the code, but the cleanup incorrectly reports a memory leak. Since no tests are run, this is not an error in lexical:

    Finished `release` profile [optimized] target(s) in 3m 40s
     Running unittests src/lib.rs (target/release/deps/lexical-cfe9a35d657545f8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

       Error leaked 56 B in 1 block
        Info stack trace (user code at the bottom)
             at malloc
             at main
     Summary Leaked 56 B total (0 other errors)
error: test failed, to rerun pass `-p lexical --lib`

Caused by:
  process didn't exit successfully: `/home/runner/.cargo/bin/cargo-valgrind /home/runner/work/rust-lexical/rust-lexical/target/release/deps/lexical-cfe9a35d657545f8` (exit status: 127)
note: test exited abnormally; to see the full output pass --nocapture to the harness.

@Alexhuszagh Alexhuszagh added the CI Related to continuous integration. label Oct 4, 2024
@Alexhuszagh Alexhuszagh self-assigned this Oct 4, 2024
@Alexhuszagh Alexhuszagh merged commit 4176535 into main Oct 4, 2024
39 checks passed
@Alexhuszagh Alexhuszagh deleted the valgrind branch October 4, 2024 03:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI Related to continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant