Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Contribution Guideline links are broken #1542

Closed
wesley-jones opened this issue May 1, 2020 · 3 comments
Closed

Contribution Guideline links are broken #1542

wesley-jones opened this issue May 1, 2020 · 3 comments
Labels
bug documentation good first issue help wanted noprogram not directly related to an Insitute program

Comments

@wesley-jones
Copy link
Contributor

Describe the bug
The table of contents and a few other links in the contribution guidelines are broken.

Do you want to work on this issue?
I can put a PR together. What branch should I target?
@kschelonka
Copy link
Contributor

@wesley-jones Thank you for noticing this. I shouldn't have relied on testing in my markdown previewer 😓 . Please target master since this is a bugfix.

wesley-jones added a commit to wesley-jones/AllenSDK that referenced this issue May 3, 2020
@wesley-jones
GH AllenInstitute#1542 - Fix broken links in contribution guidelines
32b41d1
@wesley-jones wesley-jones mentioned this issue May 3, 2020
Merged
@wesley-jones
Copy link
Contributor Author

Hey @kschelonka, no worries. I missed it as well when I was looking over it.

@wbwakeman wbwakeman added documentation noprogram not directly related to an Insitute program labels May 4, 2020
kschelonka added a commit that referenced this issue May 4, 2020
@kschelonka
Merge pull request #1547 from wesley-jones/GH-1542/bugfix/contributio…
5b5c0cd 
…n-guidelines-broken-links

Fix broken links in contribution guidelines
@kschelonka
Copy link
Contributor

kschelonka commented May 4, 2020 •
edited
Loading

Resolved by #1547.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug documentation good first issue help wanted noprogram not directly related to an Insitute program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbwakeman @wesley-jones @kschelonka