Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-factor: Simplify application handler naming #110

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Jun 14, 2024

Description

The application handler naming was originally based on CQRS conventions, but we saw that it did not help make the codebase easier to navigate. The query/command distinction maps surjectively to the first verb in the application handler name anyway, and we should free up room in our class names for other elements that may be more useful.
Correspondence has gotten a lot of application handlers, and we will need to find a better way to organize them eventually.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review June 14, 2024 07:30
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this PR should be linked to a relevant Issue.

@Ceredron Ceredron merged commit f72ce43 into main Jun 14, 2024
4 checks passed
@Ceredron Ceredron deleted the chore/re-factor-application-handlers branch June 14, 2024 09:36
@Ceredron Ceredron linked an issue Jun 14, 2024 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Støtte for å legge til eksisterende vedlegg på melding
2 participants