Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use correspondence attachment id for download attachment #127

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

Andreass2
Copy link
Collaborator

@Andreass2 Andreass2 commented Jun 24, 2024

Description

Features:

  • Use correspondence attachment id for download attachment
  • Update swagger documentation
  • Add Correspondence Ids to attachment details/overview

Fixes:

  • Fix problem with data location url not beeing present in overview/details
  • DataLocationUrl had wrong type in AttachmentOverviewExt

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron
Copy link
Collaborator

Looks good!
Remember to update spec with new correspondenceIds:
https://github.com/Altinn/altinn-studio-docs/blob/master/static/swagger/altinn-broker-v1.json

@Andreass2 Andreass2 merged commit 0f673f7 into main Jun 25, 2024
4 checks passed
@Andreass2 Andreass2 deleted the Change/correspondence-attachment branch June 25, 2024 06:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants