Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove sender from correspondence attachment #208

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Aug 15, 2024

Description

Sender is associated with the correspondence itself, not the correspondence attachment. By removing excess properties we are able to simplify the API for our consumers.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…ndence attachment. Hence it should not be exposed as a property of a correspondence attachment in the API.
@Ceredron Ceredron changed the base branch from main to fix/ef-core-datetime-with-offset August 15, 2024 12:18
@Ceredron Ceredron linked an issue Aug 15, 2024 that may be closed by this pull request
@Andreass2
Copy link
Collaborator

Det er ikke endret på database modellen, hvor sender fortsatt ligger lagret på attachmentEntity objektet.

I src\Altinn.Correspondence.Application\InitializeAttachment\InitializeAttachmentCommandHandler.cs så blir det sendt en eventbus.publish basert på sender verdien. Denne vil vell nå feile?

Ser forsåvidt at det mangler events på uploadAttachment, men det er kanskje passende å ta i en annen issue

@Ceredron
Copy link
Collaborator Author

Ceredron commented Aug 15, 2024

Det er ikke endret på database modellen, hvor sender fortsatt ligger lagret på attachmentEntity objektet.

I src\Altinn.Correspondence.Application\InitializeAttachment\InitializeAttachmentCommandHandler.cs så blir det sendt en eventbus.publish basert på sender verdien. Denne vil vell nå feile?

Ser forsåvidt at det mangler events på uploadAttachment, men det er kanskje passende å ta i en annen issue

Sender blir fortsatt mappet inn i InitializeAttachmentRequest (applikasjon) med mapperen i InitializeAttachmentMapper fra InitializeAttachmentExt (API). Forskjellen nå er at man ikke kan sende inn Sender på attachments som man legger inn i InitializeCorrespondence requesten. Den vil alltid "arve" fra correspondencen.

Base automatically changed from fix/ef-core-datetime-with-offset to main August 15, 2024 13:05
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Var jeg som overså en linje. Ser veldig bra ut

@Andreass2 Andreass2 self-requested a review August 15, 2024 13:33
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvor kommer sender fra om man kjører initializeAttachment. uten å ha en correspondence koblet til

@Ceredron Ceredron merged commit b366cdd into main Aug 15, 2024
4 checks passed
@Ceredron Ceredron deleted the fix/no-sender-in-correspondence-attachment branch August 15, 2024 14:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forberede Correspondence til release
2 participants