-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove sender from correspondence attachment #208
Conversation
… this with all DateTimeOffsets.
…ndence attachment. Hence it should not be exposed as a property of a correspondence attachment in the API.
Det er ikke endret på database modellen, hvor sender fortsatt ligger lagret på attachmentEntity objektet. I src\Altinn.Correspondence.Application\InitializeAttachment\InitializeAttachmentCommandHandler.cs så blir det sendt en eventbus.publish basert på sender verdien. Denne vil vell nå feile? Ser forsåvidt at det mangler events på uploadAttachment, men det er kanskje passende å ta i en annen issue |
Sender blir fortsatt mappet inn i InitializeAttachmentRequest (applikasjon) med mapperen i InitializeAttachmentMapper fra InitializeAttachmentExt (API). Forskjellen nå er at man ikke kan sende inn Sender på attachments som man legger inn i InitializeCorrespondence requesten. Den vil alltid "arve" fra correspondencen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Var jeg som overså en linje. Ser veldig bra ut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hvor kommer sender fra om man kjører initializeAttachment. uten å ha en correspondence koblet til
Description
Sender is associated with the correspondence itself, not the correspondence attachment. By removing excess properties we are able to simplify the API for our consumers.
Related Issue(s)
Verification
Documentation