Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Published status was overwritten by Fetch status using get details and overview #239

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

CelineTrammi
Copy link
Collaborator

Fiks for fetched status som overskriver tidligere status og lager duplikat

Description

Oppdaget ikke tidligere, men så i databasen at det kom opp Fetched 2 ganger i statuser. Dette var fordi den endret tidligere status før den lagret den nye statusen i databasen.
Fiks var å endre i databasen først og deretter hente den oppdaterte korrespondansen i samme kall. GET, endre og så GET ny.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi linked an issue Aug 28, 2024 that may be closed by this pull request
@CelineTrammi CelineTrammi marked this pull request as ready for review August 28, 2024 12:14
@CelineTrammi CelineTrammi changed the title Add status to first DB and then return updated correspondence fix: Published status was overwritten by Fetch status using get details and overview Aug 28, 2024
@CelineTrammi CelineTrammi merged commit 941f5f6 into main Aug 30, 2024
4 checks passed
@CelineTrammi CelineTrammi deleted the fix/FetchedOverridePublished branch August 30, 2024 06:20
@CelineTrammi CelineTrammi added the kind/bug Something isn't working label Oct 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetCorrespondence kall overskriver Publish status til Fetched
3 participants