Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/download before publish #268

Merged
merged 16 commits into from
Sep 16, 2024
Merged

Fix/download before publish #268

merged 16 commits into from
Sep 16, 2024

Conversation

CelineTrammi
Copy link
Collaborator

@CelineTrammi CelineTrammi commented Sep 13, 2024

Ensure download by recipient cannot happen before correspondence is published and not purged

Description

This PR contains logic which ensures that in order to download attachments for a correspondence. The user either has to be a recipient or a sender of the correspondence. Furthermore, if the user is a recipient, the correspondence has to be published and not purged yet.

Other changes:

  • A lot of files are changed because of a typo I found in a namespace.
  • _getCorrespondenceHelper -> _userClaimsHelper

I am planning on adding validation on scopes and tokens, but realized that would cause more changes and decided to take it in another PR.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi merged commit b6a65a8 into main Sep 16, 2024
4 checks passed
@CelineTrammi CelineTrammi deleted the fix/download-before-publish branch September 16, 2024 14:37
@CelineTrammi CelineTrammi added kind/bug Something isn't working kind/enhancement Improving existing feature labels Oct 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug Something isn't working kind/enhancement Improving existing feature
Projects
None yet
2 participants