-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix/download before publish #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 16, 2024
Closed
Ceredron
approved these changes
Sep 16, 2024
src/Altinn.Correspondence.Application/PurgeCorrespondence/PurgeCorrespondenceHandler.cs
Show resolved
Hide resolved
Ceredron
approved these changes
Sep 16, 2024
CelineTrammi
added
kind/bug
Something isn't working
kind/enhancement
Improving existing feature
labels
Oct 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure download by recipient cannot happen before correspondence is published and not purged
Description
This PR contains logic which ensures that in order to download attachments for a correspondence. The user either has to be a recipient or a sender of the correspondence. Furthermore, if the user is a recipient, the correspondence has to be published and not purged yet.
Other changes:
_getCorrespondenceHelper
->_userClaimsHelper
I am planning on adding validation on scopes and tokens, but realized that would cause more changes and decided to take it in another PR.
Related Issue(s)
Verification
Documentation