Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix DialogToken authentication #353

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix DialogToken authentication #353

merged 1 commit into from
Oct 15, 2024

Conversation

Ceredron
Copy link
Collaborator

Description

Follow-up to previous PR. When testing locally, I accidentally did not make the correct changes to ensure Dialogtokens were authenticated to server (instead bypassing it as we do locally). I cringe. We should consider enabling authentication when running locally when we have appsettings.local. setup alright.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…t make the correct changes to ensure Dialogtokens were authenticated to server (instead bypassing it as we do locally). I cringe. We should consider enabling authentication when running locally when we have appsettings.local. setup alright.
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing label for release notes

@Ceredron Ceredron merged commit 3f7dfa2 into main Oct 15, 2024
7 checks passed
@Ceredron Ceredron deleted the fix/dialogtoken-auth branch October 15, 2024 09:34
@CelineTrammi
Copy link
Collaborator

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants