Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include more details in InitializeCorrespondence response #355

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

CelineTrammi
Copy link
Collaborator

@CelineTrammi CelineTrammi commented Oct 15, 2024

Description

Changed InitializeCorrespondence and its response body to include more information about the correspondence created.

  • Status is included
  • Recipient is included
  • Notification details is included

The notification details contains a field for status. This tells us whether the notification order was a success, contact information was missing, or if the creation of the order failed.

This also caused many small changes to the tests, since retrieval of correspondenceId is done differently now.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi marked this pull request as ready for review October 18, 2024 07:53
@Ceredron
Copy link
Collaborator

Looks great!
However, as this is a breaking API change we should announce it in https://altinn.slack.com/archives/C068VA4SXFD
(All our consumers are still developing so should be alright).

We also need to update our OpenApi spec in altinn-studio-docs and the Postman collection in this repository.

@CelineTrammi CelineTrammi merged commit 78746b1 into main Oct 18, 2024
5 checks passed
@CelineTrammi CelineTrammi deleted the feat/change-initialize-cs-response branch October 18, 2024 12:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endre respons datastruktur for initialisering av melding
2 participants