-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
(Feature Request): Only display an approximate value of dislikes if YouTube also returns likes as an approximate value. #364
Comments
Could you provide a link to the video you used for screenshots? Also, why does your screenshot says 1.7 million dislikes while the exact number is 1752? It doesn't seem to add up to me. Anyway, the code related to writing dislike count in "compact" format is here:
|
I know this isn't really important, but he probably uses the Spanish version of YouTube, in Spanish, "Mil" means thousand. |
That's because I'm using the Spanish version of YouTube, as someone already said. Anyways, I don't think this is video-specific since I can click any video and it will be displayed just like the one I used as an example: I've also discovered that if the like counter is higher than 1 million it will be displayed with a compact format too: |
Return YouTube Dislike, GitHub Red Issues, uBlock Origin, UniversalBypass and GNOME Shell Integration I've enabled the extension to be able to run in private mode (firefox), and without signing in, this is what I see: However, if I #, it goes back to the same thing as before: |
So when you # with firefox private mode, it shows up with six figures? If it's a thing with locale's default, then probably the dislike formatting can include a detection. Also, I actually want to know how you got this. I miss the old time being able to see the exact numbers lol. |
I haven't changed any settings on my Google account, so it seems to be locale related |
To see the exact number, these lines will need to be modified:
Leaving the curly bracket empty works fine for me. Also, the function
using function That's what I can see from the source code. But it's still strange to me that your default settings gives you exact numbers below one million, but rounds up for bigger ones. The cut-off line for me is one thousand. I'm still trying to understand this, but perhaps other people more fluent with web programming can explain. To me, it seems that Youtube is using some customized version of number-shortening mechanism that is obviously doing differently for you. If that happens on the server side, there is probably nothing we can do, unless we implement an awkward way to visually check how the like counter is displayed. Plus on the programming side, correct me if I'm wrong, but why do we need to evaluate |
Here's a quick fix, just to make the like and dislike counters have the same style, but I don't like how I overwrite the youtube's like counter with the plugin's data --- is it always accurate and the same as yt's official data?
Before this line, insert:
|
You are right. Then this should work:
|
On a second thought, we could have a toggling switch to say whether or not we want exact numbers on both buttons. The function
Here's a possible way to detect if the like counter number is being shortened:
A new function |
Fix Issues Anarios#201 Anarios#364 Anarios#407 Using plugin options (Issue Anarios#387)
Fix Issues Anarios#201 Anarios#364 Anarios#407 Using plugin options (Issue Anarios#387)
Fix Issues Anarios#201 Anarios#364 Anarios#407 Using plugin options (Issue Anarios#387)
Fix Issues Anarios#201 Anarios#364 Anarios#407 Using plugin options (Issue Anarios#387)
Fix Issues Anarios#201 Anarios#364 Anarios#407 Using plugin options (Issue Anarios#387)
Extension or Userscript?
Extension
Request or suggest a new feature!
I don't know if I'm explaining this right, but here's the thing: for me, dislikes are displayed as "1,7 MIL" (as an example), while likes are displayed as an "exact value" (150.749).
Here's an example:
![image](https://user-images.githubusercontent.com/37744843/147273539-66c50bc1-c093-44ca-9be3-3c9ffb736254.png)
I can even see the exact amount of dislikes that the video has, so it shouldn't be that hard to implement it:
![image](https://user-images.githubusercontent.com/37744843/147273118-42000b14-fe1d-4447-9e68-f1c11caa09fa.png)
In case this couldn't be done; the extension could also modify the like count to an approximate value (just like the dislike count) if the user wanted to, but I don't see why wouldn't it be possible.
Ways to implement this!
A way to implement this is checking if the like count is an exact value or an approximate one. Then, change the dislike button based to a different value using the like button.
Can you work on this?
The text was updated successfully, but these errors were encountered: