Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Format dislikes number the same way likes are formatted #201

Closed
1 of 2 tasks
oSumAtrIX opened this issue Dec 5, 2021 · 1 comment · Fixed by #435
Closed
1 of 2 tasks

Format dislikes number the same way likes are formatted #201

oSumAtrIX opened this issue Dec 5, 2021 · 1 comment · Fixed by #435
Labels
enhancement New feature or request

Comments

@oSumAtrIX
Copy link
Contributor

oSumAtrIX commented Dec 5, 2021 •
edited
Loading

Extension or Userscript?

Both

Request or suggest a new feature!

This image by turnoffthelights.com shows how YouTube is formatting the dislikes count. Currently, Return YouTube Dislike lacks doing the same for specific locales.
image by turnoffthelights.com

Ways to implement this!

The front-end should format the dislikes count prior to injecting it into the HTML.
Therefore, a function can be implemented to handle the formatting of the number.

Can you work on this?

  • Yes
  • No
@oSumAtrIX oSumAtrIX added the enhancement New feature or request label Dec 5, 2021
@oSumAtrIX oSumAtrIX mentioned this issue Dec 5, 2021
Closed
@oSumAtrIX
Copy link
Contributor Author

Formatting fails on the user script for locale de_DE because the regex is wrong and should be /(\.0)|,0/.
Instead, the formatter from the user extension should be used.

@oSumAtrIX oSumAtrIX mentioned this issue Dec 23, 2021
Merged
@cyrildtm cyrildtm mentioned this issue Dec 30, 2021
Closed
3 tasks
cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this issue Jan 11, 2022
@cyrildtm
Add custom number formats
1b1f3c5 
Fix Issues Anarios#201 Anarios#364 Anarios#407
Using plugin options (Issue Anarios#387)
@cyrildtm cyrildtm mentioned this issue Jan 11, 2022
Merged
cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this issue Jan 12, 2022
@cyrildtm
Add custom number formats
2ef2766 
Fix Issues Anarios#201 Anarios#364 Anarios#407
Using plugin options (Issue Anarios#387)
cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this issue Jan 13, 2022
@cyrildtm
Add custom number formats
e941bf1 
Fix Issues Anarios#201 Anarios#364 Anarios#407
Using plugin options (Issue Anarios#387)
cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this issue Jan 13, 2022
@cyrildtm
Add custom number formats
a78159d 
Fix Issues Anarios#201 Anarios#364 Anarios#407
Using plugin options (Issue Anarios#387)
cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this issue Jan 18, 2022
@cyrildtm
Add custom number formats
a2bc4ca 
Fix Issues Anarios#201 Anarios#364 Anarios#407
Using plugin options (Issue Anarios#387)
@cyrildtm cyrildtm mentioned this issue Apr 1, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom number formats cyrildtm/return-youtube-dislike
1 participant
@oSumAtrIX