Format dislikes the same way likes are formatted #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CutestNekoAqua
approved these changes
Dec 5, 2021
| }); | ||
|
|
||
| return formatter.format(roundDown(numberState)).replace(/\.0|,0/, ""); | ||
| function numberFormat(num) { |
There was a problem hiding this comment.
maybe let the user choose what way they want it displayed?
There was a problem hiding this comment.
For the extension a toggle can be implemented into the pop-out, though for tampermonkey users another solution has be to created
|
Won't work for international users, locale has to be used |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change function
numberFormatto match the formatting on YouTube more closely.In the range of millions, YouTube hides decimals, which
numberFormatdoes not do yet.Related issue: #201