Add Cross Platform Support for toggl-cli Path

[dkvc]

Move DEFAULT_CONFIG_PATH to toggl/utils/config.py
Use absolute import in commands.py
Closes #126

[AuHau]

Thanks for the PR! It has been long standing issue :-)

I have a question though, how does this fits into multi-OS environment? I am not sure if toggl-cli really worked on Windows at some point, so that is not the platform I am concerned, but for example what about macOS? I don't think it follows XDG Base spec... So there should be some logic included that fallbacks to usage of ~ or similar if XDG_CONFIG_HOME is not defined...

[dkvc]

You are correct! It seems I failed to notice cross platform compatibility while looking through this. In such cases, pathlib.Path.expanduser("~/.togglrc"). This solution works in case of Python 3.5+.

If backward compatibility is required, then os.path.expanduser("~/.togglrc"). These solutions work throughout all platforms.

Does toggl-cli still supports any python version before 3.5?
Edit: I think it doesn't as any version before Python 3.6 is EOL. As far as difference between those two, the first one requires a Path object and returns as Path object, unlike the other. So, the first one might require more code, but it could be better long term, due to its object oriented file system paths.

[AuHau]

We are supporting only currently supported Python versions, so that means >=3.7 (3.7 soon will be gone as well), so both options are fine ;-) I will leave that up to you choose.

The only thing I would ask you is, can you please either rebase or recreate the PR? I have been doing some bad stuff (eq. force pushing master 🙈 😅 ) in order to get the new CI release mechanism working... Which finally does, but it bit corrupted your PR unfortunately, sorry about that.

[dkvc]

Sure, no worries 👍

[dkvc]

I don't think DEFAULT_CONFIG_PATH in commands.py is doing anything. It can be a oversight. Can you take a look over it?

[AuHau]

You are right :-) It is the one in config.py that is used... Good catch!