-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature: allow 'misspellings' that are identifiers #160
Comments
This is actually already implemented for identifiers that aren't either snake_case or chain-case. I'll look into getting this done sometime early next week. Sorry for the delay! |
It looks like @grantlemons is looking into this. Grant: I'd suggest creating a new Harper |
… is_case_seperator comment to tokens.rs
We're actually going to reopen this issue until we have a release out that @dvdsk can confirm no longer has the problem. |
Thank you all very much for working on this! Ill go try it out immediately and let you know how it works after the weekend 👍 |
Worked in most cases 🎉. I ran into one issue thats still there but I think it has a different cause. So great work thanks you all very much! I will make a new report for the new issue. |
nvmd it all works perfectly! No other issues on my end 🥳 |
Apologies if this is spamy. But this feature just really helped my out. I refactored an API and forgot to update the docs. Harper gave me spell errors for words that where identifiers of the previous API. Very very nice |
Not spamy at all. That actually makes us so happy. Glad Harper is doing something good. |
Context:
I have a doc comment naming an identifier (in this case an parameter of the function). It has an underscore and harper highlights that as a spelling mistake.
Benefits:
Details:
Should probably not allow all identifiers (maybe a config option), function names and parameter names might be a good default.
related: #29
The text was updated successfully, but these errors were encountered: