feat: Collapse identifiers seperated by hyphens or underscores if they exist in the file dictionary #199
Conversation
|
Tests need to be fixed. |
| @@ -242,6 +242,11 @@ impl TokenKind { | |||
| matches!(self, TokenKind::Punctuation(Punctuation::At)) | |||
| } | |||
|
|
|||
| pub fn is_case_separator(&self) -> bool { | |||
There was a problem hiding this comment.
This should probably be two separate functions, but it's probably OK for now. If someone really wants it I can figure out how to do OR in pattern matching.
There was a problem hiding this comment.
It's probably fine to leave this here, but if you do, add a doc-comment that explains what a "case separator" is and why it's needed.
I would much rather create an OR Pattern and use that though, since we need one anyway. It's up to you which you decide to do (laziness is totally fine in this case).
|
Overall, this is really great work @grantlemons. I've left a few (nitpicky) comments on some bits. They should be pretty straightforward changes. Other than those, would you mind changing your commit messages to match Conventional Commits? Feel free to force-push to the feature branch. I would also mention issue #160 in them: |
| @@ -242,6 +242,11 @@ impl TokenKind { | |||
| matches!(self, TokenKind::Punctuation(Punctuation::At)) | |||
| } | |||
|
|
|||
| pub fn is_case_separator(&self) -> bool { | |||
There was a problem hiding this comment.
It's probably fine to leave this here, but if you do, add a doc-comment that explains what a "case separator" is and why it's needed.
I would much rather create an OR Pattern and use that though, since we need one anyway. It's up to you which you decide to do (laziness is totally fine in this case).
| pub use markdown::Markdown; | ||
| pub use mask::Mask; | ||
| pub use plain_english::PlainEnglish; | ||
|
|
||
| pub use crate::token::{Token, TokenKind, TokenStringExt}; | ||
|
|
||
| #[cfg(not(feature = "concurrent"))] |
There was a problem hiding this comment.
I'm surprised this wasn't already here. How was harper-cli able to compile?
There was a problem hiding this comment.
Idk, I just checked, and it turns out mask::Masker uses Sync too and doesn't have a concurrent cfg.
…mmentParser with it
grantlemons
force-pushed
the
collapse_seps
branch
from
684c4b0 to
3e322c9
Compare
… is_case_seperator comment to tokens.rs
No description provided.