MAINT Update gcg_attack.py #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! We also need to reexamine our dependencies to upgrade... I'll create an issue for that. |
jbolor21
approved these changes
Dec 16, 2024
romanlutz
pushed a commit
that referenced
this pull request
Dec 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
np.inftyis used ingcg_attack.py.However,
np.inftywas deprecated as an alias ofnp.infin NumPy 2.0.0 (https://numpy.org/devdocs/release/2.0.0-notes.html).Since PyRIT uses NumPy 1.26.4 at the moment, it still works!
However, 2.0.0 is the release right after 1.26.4, so it might be good to change ahead of time since
np.infworks either way.This might be of relevance to Issue #532 since Python 3.13 is supported only by NumPy 2.1.0+.
Tests and Documentation