Skip to content

Commit

Permalink
Hacky fix of subresource for networking (#4430)
Browse files Browse the repository at this point in the history
This fixes the SubResource from DnsResolver to match
the SubResource from core networking so that we don't have a million
different <Resource>SubResource's created.

The issue is that dnsresolver and networking are two different Swagger
specifications from two different Swagger folders that both put
resources into the networking group. The 2022-07-01 API just happened to
be supported by both networking and dnsresolver, but many subsequent API
versions of plain networking don't correspond to a dnsresolver version.
This results in inconsistencies between type names in the two versions
of core networking which causes issues adding a new networking version
due to conversion problems.
  • Loading branch information
matthchr authored Nov 11, 2024
1 parent 8e7e143 commit 6a95721
Show file tree
Hide file tree
Showing 83 changed files with 2,071 additions and 3,644 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions v2/api/network/v1api20201101/storage/structure.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1144,4 +1144,5 @@ augmentConversionForExtendedLocation: Interface
augmentConversionForExtendedLocation_STATUS: Interface
augmentConversionForIpTag: Interface
augmentConversionForIpTag_STATUS: Interface
augmentConversionForSubResource: Interface
augmentConversionForSubResource_STATUS: Interface
Loading

0 comments on commit 6a95721

Please # to comment.