Bug: StorageAccount is not storing credentials as a secret

[cnadolny]

Describe the bug
We currently do not store credentials for the storage account. We should store those in a secret, and remove the StorageOutput struct, which is not being used either.

type StorageOutput struct {
	StorageAccountName string `json:"storageAccountName,omitempty"`
	Key1               string `json:"key1,omitempty"`
	Key2               string `json:"key2,omitempty"`
	ConnectionString1  string `json:"connectionString1,omitempty"`
	ConnectionString2  string `json:"connectionString2,omitempty"`
}

To Reproduce
Steps to reproduce the behavior:
Create SA, no secret is created

Expected behavior
When creating a storage account, a secret should be created with credentials for connecting to the storage account, with the following fields:

	StorageAccountName string `json:"storageAccountName,omitempty"`
	Key1               string `json:"key1,omitempty"`
	Key2               string `json:"key2,omitempty"`
	ConnectionString1  string `json:"connectionString1,omitempty"`
	ConnectionString2  string `json:"connectionString2,omitempty"`

Completion Criteria

• Secret is created with credentials
• StorageOutput struct is removed from types.go
• Docs are updated with secret information

[WilliamMortlMicrosoft]

@frodopwns Blocked until Mel's PR goes through - as per @jananivMS 's instructions

[WilliamMortlMicrosoft]

Will likely get back to work on this on Tuesday 4/14

[WilliamMortlMicrosoft]

remove structs from storageaccount_types.go

[WilliamMortlMicrosoft]

line 169 on hub.go... Upsert

[WilliamMortlMicrosoft]

@cnadolny quick question... I haven't work in this area of code yet... can you tell me what function / struct that:

	StorageAccountName string `json:"storageAccountName,omitempty"`
	Key1               string `json:"key1,omitempty"`
	Key2               string `json:"key2,omitempty"`
	ConnectionString1  string `json:"connectionString1,omitempty"`
	ConnectionString2  string `json:"connectionString2,omitempty"`

are obtained from? Thanks! :-)

[jananivMS]

@WilliamMortlMicrosoft You'll need to call the ListKeys method on the storage account for the keys
https://godoc.org/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2018-07-01/storage#AccountsClient.ListKeys

And you will need to construct the connection string using the below format
DefaultEndpointsProtocol=https;AccountName=;AccountKey===;EndpointSuffix=<ENVIRONMENT_SPECIFIC_SUFFIX>

ENVIRONMENT_SPECIFIC_SUFFIX can be gotten in the code using resourcemanagerconfig.Environment().StorageEndpointSuffix

[WilliamMortlMicrosoft]

Thanks so much @jananivMS !!!!! Where did you find that? :-)