WIP: Store storage account credentials #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmosDB test region workaround (#896)
reset failed provisioning in case the outcome changes
| storageManagers = resourcemanagerstorages.AzureStorageManagers | ||
| storageAccountManager := resourcemanagerstorageaccount.New() | ||
| storageManagers = resourcemanagerstorages.AzureStorageManagers(secretClient, scheme.Scheme) | ||
| storageAccountManager := resourcemanagerstorageaccount.New(secretClient, scheme.Scheme) | ||
| blobContainerManager := resourcemanagerblobcontainer.New() | ||
| keyVaultManager := resourcemanagerkeyvaults.NewAzureKeyVaultManager(k8sManager.GetScheme()) |
There was a problem hiding this comment.
@frodopwns @jananivMS are scheme.Scheme and k8smanager.Scheme interchangeable? I see that some use one, while others use the other... I used scheme.Scheme as it looked more prevalent. Could that be wrong?
added 2 commits
April 24, 2020 13:27
…ce-operator into credentialsFix
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #913
Upserts the credentials - haven't tested yet
Due to inter-dependencies in storages, this PR touches other resource managers. The code is a bit wonky, but I struggled with finding a better way to do this.
CURRENT STATUS: it should work, but I will test in the AM