-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Public GitHub Actions for build and test #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks for doing this.
dpkg-reconfigure -f noninteractive tzdata | ||
- name: Install dependencies | ||
run: | | ||
scripts/install-deps.sh --install-aduc-deps --install-do --install-cmake --install-shellcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not doing -a instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -a
requires the install of --install-githooks
which fails (see log below).
I suspect would need to also checkout of .git
folder and a git config --global --add safe.directory "$(pwd)"
for the hooks to work. None of these are needed in CI.
Installing githooks...
Unable to determine git root.
Error: Process completed with exit code 1.
Example build with the error shown:
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/13541395990/job/37843105763#step:5:2124
Source of the error:
https://github.com/Azure/iot-hub-device-update/blob/develop/scripts/install-deps.sh#L159
I wonder if -a
should include the git hooks because this dependency is more of a developer convenience, for CI builds it does not seem relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. the git rev-parse evidently not working, so would need to try the safe-directory you mentioned. Already have --install-githooks which would still be a part of -a. I think we can add , say, a --install-ghactions for github action pipelines that encapsulates what you've done here.
60af4ee
to
cf8c131
Compare
Not sure why the build on Debian 10 failed. CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
CMake 3.16 or higher is required. You are running version 3.13.4
Seems catch2 is still using the system cmake version to compile. |
As suggested in discussion "Public GitHub Actions builds"
#688
Example run:
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/12871357147