Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Public GitHub Actions for build and test #689

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

AndreRicardo-Zoetis
Copy link
Contributor

As suggested in discussion "Public GitHub Actions builds"
#688

Example run:

https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/12871357147

@AndreRicardo-Zoetis AndreRicardo-Zoetis changed the title Public GitHub Actions for build and test. Public GitHub Actions for build and test Feb 20, 2025
jw-msft
jw-msft previously approved these changes Feb 25, 2025
Copy link
Contributor

@jw-msft jw-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for doing this.

dpkg-reconfigure -f noninteractive tzdata
- name: Install dependencies
run: |
scripts/install-deps.sh --install-aduc-deps --install-do --install-cmake --install-shellcheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not doing -a instead?

Copy link
Contributor Author

@AndreRicardo-Zoetis AndreRicardo-Zoetis Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -a requires the install of --install-githooks which fails (see log below).

I suspect would need to also checkout of .git folder and a git config --global --add safe.directory "$(pwd)" for the hooks to work. None of these are needed in CI.

Installing githooks...
Unable to determine git root.
Error: Process completed with exit code 1.

Example build with the error shown:
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/13541395990/job/37843105763#step:5:2124

Source of the error:
https://github.com/Azure/iot-hub-device-update/blob/develop/scripts/install-deps.sh#L159

I wonder if -a should include the git hooks because this dependency is more of a developer convenience, for CI builds it does not seem relevant.

Copy link
Contributor

@jw-msft jw-msft Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. the git rev-parse evidently not working, so would need to try the safe-directory you mentioned. Already have --install-githooks which would still be a part of -a. I think we can add , say, a --install-ghactions for github action pipelines that encapsulates what you've done here.

@jw-msft jw-msft merged commit d83ea71 into Azure:develop Feb 27, 2025
1 check passed
@AndreRicardo-Zoetis
Copy link
Contributor Author

Not sure why the build on Debian 10 failed.

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.16 or higher is required.  You are running version 3.13.4

https://github.com/Azure/iot-hub-device-update/actions/runs/13556459435/job/37891642088#step:5:2665

--install-cmake is passed and the version on install-deps.sh is supported_cmake_version='3.23.2'

Seems catch2 is still using the system cmake version to compile.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants