Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecate InstalledFlowRate under FanSystem #351

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Deprecate InstalledFlowRate under FanSystem #351

merged 2 commits into from
Jun 1, 2021

Conversation

JieXiong9119
Copy link
Contributor

@JieXiong9119 JieXiong9119 commented May 24, 2021 •
edited by nllong
Loading

See proposal.

Fixes #264

@JieXiong9119 JieXiong9119 self-assigned this May 24, 2021
@JieXiong9119 JieXiong9119 changed the base branch from develop to develop-v3 May 24, 2021 16:38
@JieXiong9119 JieXiong9119 linked an issue May 24, 2021 that may be closed by this pull request
Deprecate auc:FanSystem/auc:InstalledFlowRate #264
Closed
nllong
nllong approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@nllong nllong merged commit eff10a2 into develop-v3 Jun 1, 2021
@nllong nllong deleted the deprecate/installedflowrate branch June 1, 2021 19:14
@JieXiong9119 JieXiong9119 mentioned this pull request Jun 4, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nllong nllong nllong approved these changes

@macintoshpie macintoshpie Awaiting requested review from macintoshpie

Assignees

@JieXiong9119 JieXiong9119

Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate auc:FanSystem/auc:InstalledFlowRate
2 participants
@JieXiong9119 @nllong