Feat/v2 to v3 translation updates #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Initial implement changes for WallID WindowID DoorID PrimaryHVACSystemType 2. Create Python script for PC users 3. Update README.md
I just created a test.xml file in the subfolder. Could you take a look? |
macintoshpie
suggested changes
Jun 11, 2021
There was a problem hiding this comment.
Hey Jie, I moved your example file into the spec/data/v2_for_translation.xml file b/c this is the one that actually gets tested.
After doing that there are some failures, it looks like we are still missing some translations. Could you add them to the translator?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes follow-up updates on the version translation tool developed in #348. The updated v2_to_v3.xsl file should bring in all the breaking changes from v2 to v3, for transforming BuildingSync v2 xml instances to v3 (via any xslt processor).
What are the relevant PRs?
Breaking changes that are accounted for in #348:
/with spaces #335Breaking changes added into xsl on this PR:
Convert to Cleaner FuelstoConvert to cleaner fuels#334