-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CRDCDH-594 Submit Using Validation Status #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic seems to incorrectly allow for submission in these scenario(s):
metadataValidationStatus | fileValidationStatus |
---|---|
null |
Passed |
null |
null |
My understanding is that, at a minimum, all submissions need metadata? It may not be possible for this scenario to occur in a real submission, but I would recommend we cover for it.
Other scenarios tested and working as expected:
metadataValidationStatus | fileValidationStatus |
---|---|
Passed |
null |
Warning |
null |
Passed |
Passed |
Passed |
Warning |
Warning |
Passed |
Updated to disable submit if metadataValidationStatus is null. Also added refresh for submission when an upload occurs, because the validation statuses get updated. |
Overview
This PR aims to use
metadataValidationStatus
andfileValidationStatus
properties from the submission, instead of the stat nodes, to decide whether or not to disable the submit button. This is so that the FE and BE are both on the same page.Change Details (Specifics)
N/A
Related Ticket(s)
CRDCDH-594
CRDCDH-635