CRDCDH-635 Admin Submit #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
previously approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Aside from the scenarios mentioned in #253, everything LGTM. Will merge after that PR.
Admin override functionality scenarios tested:
| metadataValidationStatus | fileValidationStatus |
|---|---|
Error |
Error |
Error |
Warning |
Warning |
Error |
Error |
null |
… restrict user roles for submit
Alejandro-Vega
changed the base branch from
CRDCDH-594-validation-status
to
mvp-2.1.0
amattu2
approved these changes
Jan 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to transition to use
metadataValidationStatusandfileValidationStatusproperties from the submission, instead of the stat nodes, to decide whether or not to disable the submit button. It also adds "Admin Submit" to the data submission process to allow bypassing error nodes.Change Details (Specifics)
Related Ticket(s)
CRDCDH-594
CRDCDH-635