Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #2099 + fix issue when creating an edge device #2101

Merged
merged 1 commit into from
May 23, 2023

Conversation

kbeaugrand
Copy link
Member

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand temporarily deployed to E2E May 23, 2023 11:48 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand force-pushed the fix/2099_remove_deprecated_ud_avatar branch from ef1b23b to fa15330 Compare May 23, 2023 12:01
@kbeaugrand kbeaugrand temporarily deployed to E2E May 23, 2023 12:01 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand changed the title Fix #2099 + fix issue when creating a ne edge device Fix #2099 + fix issue when creating an edge device May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 71.42% and no project coverage change.

Comparison is base (ebe1bf4) 92.39% compared to head (e002a3b) 92.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2101   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         277      277           
  Lines        9128     9129    +1     
=======================================
+ Hits         8434     8435    +1     
  Misses        694      694           
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 66.01% <ø> (ø)
...Client/Pages/EdgeModels/CreateEdgeModelsPage.razor 81.41% <ø> (ø)
....Client/Pages/EdgeModels/EdgeModelDetailPage.razor 83.21% <ø> (ø)
....Portal.Client/Components/Devices/EditDevice.razor 93.87% <42.85%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 69.94% <66.66%> (ø)
...lient/Pages/EdgeDevices/CreateEdgeDevicePage.razor 83.33% <70.00%> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 90.60% <100.00%> (+0.05%) ⬆️
...eIoTHub.Portal.Shared/Models/v1.0/IoTEdgeDevice.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the fix/2099_remove_deprecated_ud_avatar branch from fa15330 to 21d6211 Compare May 23, 2023 12:22
@kbeaugrand kbeaugrand temporarily deployed to E2E May 23, 2023 12:22 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand marked this pull request as ready for review May 23, 2023 12:26
@kbeaugrand kbeaugrand requested a review from a team as a code owner May 23, 2023 12:26
@kbeaugrand kbeaugrand force-pushed the fix/2099_remove_deprecated_ud_avatar branch from 21d6211 to e002a3b Compare May 23, 2023 12:37
@kbeaugrand kbeaugrand temporarily deployed to E2E May 23, 2023 12:37 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand enabled auto-merge (squash) May 23, 2023 12:38
@kbeaugrand kbeaugrand disabled auto-merge May 23, 2023 12:54
@kbeaugrand kbeaugrand merged commit 4ec0a5e into main May 23, 2023
@kbeaugrand kbeaugrand deleted the fix/2099_remove_deprecated_ud_avatar branch May 23, 2023 13:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: MudBlazor - MudAvatar.Image is obsolete
2 participants