Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use consistent labels: print screen vs tuning screen #115

Closed
ztakis opened this issue Jan 1, 2021 · 11 comments
Closed

Use consistent labels: print screen vs tuning screen #115

ztakis opened this issue Jan 1, 2021 · 11 comments
Assignees
Labels
t:enhancement New feature or request

Comments

@ztakis
Copy link

ztakis commented Jan 1, 2021

Description

Print Screen shows feed rate not printing speed

Expected behavior:

Print Screen shows feed rate instead of printing speed which is confusing as Tune Screen shows the expected printing speed adjustment. I think it would be better that Print Screen to display just FLOW SPEED FAN.

@Sebazzz
Copy link
Collaborator

Sebazzz commented Jan 2, 2021

This is about the inconsistency in the labels I guess? The underlying data is the same: Marlin has no concept of print speed - only feed rate.

@Sebazzz Sebazzz added the t:enhancement New feature or request label Jan 2, 2021
@Sebazzz Sebazzz changed the title Print Screen shows feed rate not printing speed Use consistent labels: print screen vs tuning screen Jan 7, 2021
@Sebazzz Sebazzz added this to the Community Release 6 milestone Jan 7, 2021
@Thinkersbluff
Copy link

When we added control over Flow Rate, we also introduced the Feed Rate label, without going back & making other screens consistent with that term.

As an Engineer, I find units of "%" make more sense for Rates than for Speeds.
Users with no prior experience of CNC or RepRap jargon are probably less comfortable with arcane terms like "Feed Rate", but it is certainly embedded in Marlin and in their LCD menus. What terminology are you using for the BTT TFT Marlin mode menus?

To me, it makes a lot of sense to retain consistency with the legacy terms Standardizing on RepRap vocabulary should facilitate a more rapid understanding of all 3D printing resources for newcomers.

@Sebazzz
Copy link
Collaborator

Sebazzz commented Feb 5, 2021

Yes - so update the Tune screen by replacing "Printing speed" with "Feed rate".

@grobux I think you are quicker than me. Come to think of it, the bed temperature and nozzle temperatures use the same icon - is that intentional?

@BubuMVX
Copy link

BubuMVX commented Feb 5, 2021

No problem, I'll do it.

The bed temperature and nozzle temperatures use the same icon - is that intentional?

A bit of laziness maybe. 😋 Also, in the icon lib used, the main differences around the "temperature" keyword is basically the height of the temp gauge. Anyway, I'll check that too.

@BubuMVX
Copy link

BubuMVX commented Feb 5, 2021

Fixed by CR6Community/CR-6-touchscreen@d8d9133

I took the opportunity to make new custom icons for bed and nozzle temperatures. Very simple, based on the ones in the footer and a bit larger than other menu icons, but more clear I guess. I put them everywhere they were needed. I'm open to better ideas and suggestions.

41_E_adjust

@jwrayburn
Copy link

jwrayburn commented Feb 6, 2021 via email

@ztakis
Copy link
Author

ztakis commented Feb 6, 2021

May I suggest some icons for flow rate?

image

@Sebazzz
Copy link
Collaborator

Sebazzz commented Feb 6, 2021

Flow rate is extrusion rate, so I would suggest something that looks like an extruder. Marlin has already a similar icon for generic TFTs, check here - second picture.

@Sebazzz
Copy link
Collaborator

Sebazzz commented Feb 14, 2021

@grobux Are these icons useful to you? I think the gray part is like a transparency key.

flowrate
Flow rate [extrusion multiplier]

feedrate
Feed rate [print speed]

hotend
Hot-end

bed
Bed

bed_heated
Bed (heating)

More icons can be found in the Marlin/src/lcd/tft/bitmaps folder.

So to complete this issue:

  • Rename "print speed" to "feed rate" (done)
  • Perhaps take a look at the icons but that is up to you @grobux 🙂

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 1, 2021
Updates printing, paused and print finish screens

CR6Community/Marlin#115
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 1, 2021
Updates printing, paused and print finish screens - bitmaps
ICLs and reshuffling of the DWIN screen elements is still to be done

CR6Community/Marlin#115
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 1, 2021
ICLs and reshuffling of the DWIN screen elements is still to be done

CR6Community/Marlin#115
@Sebazzz
Copy link
Collaborator

Sebazzz commented Mar 1, 2021

@ztakis did some updates to the printing screen which I have committed to the repository. DWIN part is still to be done.

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
@Sebazzz
Copy link
Collaborator

Sebazzz commented Mar 3, 2021

image

Current screen implemented by @ztakis with a bit of #208 mixed into it already.

For this item this has now been implemented and I'Il close this issue.

If anyone feels strong about feed rate vs print speed, flow rate vs extrusion multiplier, let's open a new issue for that.

Thanks again for @ztakis for implementing this.

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants