Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FR] Support M73 R gcode #208

Closed
Sebazzz opened this issue Mar 2, 2021 · 5 comments
Closed

[FR] Support M73 R gcode #208

Sebazzz opened this issue Mar 2, 2021 · 5 comments
Labels
area:dwin-interop Area - DWIN interop t:enhancement New feature or request

Comments

@Sebazzz
Copy link
Collaborator

Sebazzz commented Mar 2, 2021

Description

Description of the bug or requested feature
image

PrusaSlicer supports this feature, and although it isn't documented Marlin supports it under the hood.

How would it work

When M73 R[time] is used then the time is set using the regular status messages.
@Sebazzz Sebazzz added area:dwin-interop Area - DWIN interop t:enhancement New feature or request labels Mar 2, 2021
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 2, 2021

Relevant PR upstream: MarlinFirmware#15549

Sebazzz added a commit that referenced this issue Mar 2, 2021
@Sebazzz
Enable M73 remaining time support for BTT TFT #208
abd0855
Sebazzz added a commit that referenced this issue Mar 2, 2021
@Sebazzz
Implement initial M73 remaining support #208
ad407de
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 2, 2021

Okay, this works but currently "abuses" the M117 status message to push the remaining print time.
I'd rather have a separate time control for that. For instance: as a sub line below the main print time.

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
@Sebazzz
Send print time as a separate value to the display
7dc4e7f 
CR6Community/Marlin#208
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
@Sebazzz
Send print time alignment improvements
97cb3d4 
    CR6Community/Marlin#208
Sebazzz added a commit that referenced this issue Mar 2, 2021
@Sebazzz
Send print time as a separate value to the display #208
1896f47
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 2, 2021

Touch screen is in a rough shape right now.

Looping in @grobux and @ztakis because I've edited the bitmaps for this prototype and not the PSD.

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 2, 2021
@Sebazzz
Send print time alignment improvements
57e7f9c 
    CR6Community/Marlin#208
@Sebazzz Sebazzz mentioned this issue Mar 3, 2021
Closed
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 3, 2021

Okay this works fine when your gcode slicer (PrusaSlicer) or host (Octoprint with Detailed Progress) supports it, but if your gcode doesn't support it, then the default estimation of Marlin is wildly inaccurate.

Calibration cube example:

image

Eventually it does come around, but still:

image

So I'm going to hide the "remaining" when there is no estimate and re-align the main print progress.

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
@Sebazzz
Assign SPs for print progress
058c365 
CR6Community/Marlin#208
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
@Sebazzz
Assign hide remaining progress icon
e69364e 
CR6Community/Marlin#208
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
@Sebazzz
Temporary kill the print timer because DWIN is killing me
717cc00 
CR6Community/Marlin#208
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Mar 3, 2021
@Sebazzz
Use two seperate print timer VPs for display
65455c5 
The only way I can make this piece of work behave. I tried everything else:
- Stack pointers refuse to operate, even on colors (though it worked fine for other screens)
- I can't unset the VP
- I can't do a text length change
- I can't change the position

CR6Community/Marlin#208
Sebazzz added a commit that referenced this issue Mar 3, 2021
@Sebazzz
Swap print timer when a remaining time available is available #208
5b4a8d2
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 3, 2021

Okay, I had a good fight with the DWIN touch screen now the entire evening, but I got it now.

If no M73 R is issued:

image

When a M73 R is issued then:

image

@Sebazzz Sebazzz closed this as completed Mar 3, 2021
@Sebazzz Sebazzz mentioned this issue Mar 3, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area:dwin-interop Area - DWIN interop t:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sebazzz