Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deploy-via-git bash script error #13

Closed
makstaks opened this issue Jul 31, 2020 · 0 comments · Fixed by #14
Closed

deploy-via-git bash script error #13

makstaks opened this issue Jul 31, 2020 · 0 comments · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@makstaks
Copy link

makstaks commented Jul 31, 2020

Orb Version

1.2.0

Describe the bug
Getting an error with bash script

/bin/bash: line 4: heroku_url: command not found

Exited with code exit status 127

I think the heroku_url has some unwanted whitespace around the = sign, so it is being treated as a command instead of as a variable assignment.

To Reproduce

I'm using this orb via CircleCI, here is my configuration:

  deploy-production:
    executor: heroku/default
    environment:
      HEROKU_APP_NAME: <our app name>
    steps:
      - checkout
      - heroku/deploy-via-git:
          force: true
          branch: HEAD

Expected behavior

No errors when executing bash script.

Additional context

We were able to successfully deploy this morning with the previous version of the bash script:

#!/bin/bash -eo pipefail
if true;then
  force="-f"
fi
git push $force https://heroku:$HEROKU_API_KEY@git.heroku.com/$HEROKU_APP_NAME.git HEAD:master
@makstaks makstaks added the bug Something isn't working label Jul 31, 2020
fuzzylita added a commit to rainforestapp/ci-sample that referenced this issue Aug 3, 2020
Most recent version of the heroku orb has syntax errors
CircleCI-Public/heroku-orb#13
@gmemstr gmemstr self-assigned this Aug 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants