Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[semver:patch] Fix setting variables in bash #14

Merged
merged 1 commit into from
Aug 14, 2020
Merged

[semver:patch] Fix setting variables in bash #14

merged 1 commit into from
Aug 14, 2020

Conversation

a14m
Copy link
Contributor

@a14m a14m commented Aug 4, 2020

Fixes #13

@tanansatpal
Copy link

Can we have this change merged guys? It is useless now without this change

@a14m
Copy link
Contributor Author

a14m commented Aug 11, 2020

You can use this fork https://circleci.com/orbs/registry/orb/sapera/heroku-orb
It's based on this #12
but uses ref key instead of branch to work with both tags/branches... we've been using it for production (for short time now) and it's been working fine,
I've cleaned the git history, but you can check the difference between the fork and the 1.1.1 version here:
infographicsgroup@ea05c65

Copy link
Contributor

@gmemstr gmemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for tests to pass before merging

@gmemstr gmemstr changed the title Fix setting variables in bash [semver:patch] Fix setting variables in bash Aug 14, 2020
@gmemstr gmemstr merged commit 253e0fb into CircleCI-Public:master Aug 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy-via-git bash script error
4 participants