Skip to content

Forks problem: add an organisation or owner check to run the action #2

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
bigcat88 opened this issue Jul 14, 2024 · 5 comments
Closed
Assignees

Comments

@bigcat88
Copy link

When you update a forked ComfyUI Node, the publishing action is constantly triggered and fails.

Can this if: ${{ github.repository_owner == 'NODE_AUTHOR_OWNER' }} be added to the example and to all PRs that this organisation creates to the ComfyUI Nodes, please?

This will prevent action from trigger and it is a default practice how it is usually done, thanks.

@yoland68
Copy link
Member

@snomiao Can you take a look at this?

@snomiao
Copy link
Member

snomiao commented Dec 20, 2024

let me check

snomiao added a commit to Comfy-Org/Comfy-PR that referenced this issue Dec 31, 2024
- [Forks problem: add an organisation or owner check to run the action · Issue #2 · Comfy-Org/publish-node-action]( Comfy-Org/publish-node-action#2 (comment) )
@snomiao
Copy link
Member

snomiao commented Jan 3, 2025

The repository owner name filter has been added. From now on, when creating new pull requests, "NODE_AUTHOR_OWNER" will be replaced by the repository owner's name. For example, when creating a PR for the snomiao/ComfyNode-Registry-test repository, the publish.yml will look like this:

      if: ${{ github.repository_owner == 'snomiao' }}

This change should prevent the publishing action from being constantly triggered and failing.

References:

@yoland68
Copy link
Member

yoland68 commented Jan 3, 2025

Nice, so going forward, new custom node repos that get's publish.yml PR will contain the repository_owner line right?

@snomiao
Copy link
Member

snomiao commented Jan 3, 2025

Nice, so going forward, new custom node repos that get's publish.yml PR will contain the repository_owner line right?

yes

This was referenced Apr 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants