Skip to content

Update Github Action for Publishing to Comfy Registry #24

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

robinjhuang
Copy link

Hey! My name is Robin and I'm from comfy-org! We would love to have you join the Comfy Registry, a public collection of custom nodes which lets authors publish nodes by version and automate testing against existing workflows. This PR updates the Github Action publish.yml to ensure latest ComfyUI Community Standard.

Updates:

  1. Issue Creating Permission: Ensures that the workflow can open issues to report publishing states or warnings, facilitating better communication and issue tracking.
+ # auto issue permission, for Comfy CustomNode registry publishing state
+ permissions:
+   issues: write
  1. Conditional Execution: Only runs the publish job in author’s repo, defaults to repo owner, reference issue here: - Forks problem: add an organisation or owner check to run the action · Issue #2 · Comfy-Org/publish-node-action
-     if: github.event.repository.fork == false 
+     if: ${{ github.repository_owner == 'GiusTex' }}
  1. Versioning: We use explicity version number after stable release, using a stable release version of the action reduces the
    risk of unexpected behavior from changes in the action's main branch.
-     uses: Comfy-Org/publish-node-action@~~main~~
+     uses: Comfy-Org/publish-node-action@v1

Learn More

Please message me on Discord at robin or join our server server if you have any questions! For more information, visit the official Comfy-Org blog: ComfyUI Blog.

- Add permissions for issue writing in the workflow
- Modify condition to check repository owner instead of fork status
- Update action version from `main` to `v1` for stability and consistency
@GiusTex GiusTex merged commit 6bf7bde into GiusTex:main Apr 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants