Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cap new rating before computing new volatility #1738

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

Ninjaclasher
Copy link
Member

This code should also have been moved in #840, but was missed. Currently, the new volatility is based on the uncapped new rating instead of the capped new rating.

Thanks to @int-y1 for finding this.

@codecov-commenter
Copy link

Codecov Report

Merging #1738 (afdd20d) into master (ba7b768) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1738   +/-   ##
=======================================
  Coverage   46.50%   46.50%           
=======================================
  Files         220      220           
  Lines       12445    12445           
=======================================
  Hits         5787     5787           
  Misses       6658     6658           
Impacted Files Coverage Δ
judge/ratings.py 18.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7b768...afdd20d. Read the comment docs.

@quantum5 quantum5 merged commit 38f3f8b into DMOJ:master Jul 4, 2021
@Ninjaclasher Ninjaclasher deleted the new-rating-cap branch July 4, 2021 01:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants