Update new_rating before computing new_volatility. #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for finding this Nick! |
quantum5
approved these changes
Dec 28, 2018
qazokm
pushed a commit
to uwapcs/DMOJ-site
that referenced
this pull request
Dec 28, 2018
outloudvi
pushed a commit
to SchOJ/site
that referenced
this pull request
Jan 12, 2019
SchrodingerZhu
pushed a commit
to SchOJ/site
that referenced
this pull request
Feb 6, 2019
Ninjaclasher
pushed a commit
to Ninjaclasher/site
that referenced
this pull request
Mar 3, 2019
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new_rating is initialized to always be equal to old_rating, which explains why volatility never increased for any users