Adds a more accurate description of container rss metric #19767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
reviewed
Mar 5, 2025
| @@ -17,7 +17,7 @@ container.memory.limit,gauge,,byte,,The container memory limit,0,container,mem_l | |||
| container.memory.major_page_faults,count,,,,Number of major page faults incurred,0,container,pgmajfault, | |||
| container.memory.oom_events,gauge,,,,The number of OOM events triggered by the container,0,container,mem_oom_events, | |||
| container.memory.page_faults,count,,,,Total number of page faults incurred,0,container,pgfault, | |||
| container.memory.rss,gauge,,byte,,The container RSS usage,0,container,mem_rss, | |||
| container.memory.rss,gauge,,byte,,The 'anon' memory used by the container,0,container,mem_rss, | |||
There was a problem hiding this comment.
We can perhaps improve more with the Kernel description:
Amount of memory used in anonymous mappings such as brk(), sbrk(), and mmap(MAP_ANONYMOUS)
There was a problem hiding this comment.
I was hesitant to include more specific linux concepts as this appears to be cross-platform, and I don't know what this reports on windows.
There was a problem hiding this comment.
It's a Linux-only metric.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the
container.memory.rssdescription to be more accurate.Motivation
The
container.memory.rssmetric reports only the 'anonymous' portion of the container memory.This is potentially confusing as the term RSS is typically used to describe the combination of
RssAnon, RssFile, and RssShmemwhen looking at a process-view.However, a container-view will use
rssto refer to only theanonportion of the memory.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged