Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds a more accurate description of container rss metric #19767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds a more accurate description of container rss metric #19767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container/metadata.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ container.memory.limit,gauge,,byte,,The container memory limit,0,container,mem_l
container.memory.major_page_faults,count,,,,Number of major page faults incurred,0,container,pgmajfault,
container.memory.oom_events,gauge,,,,The number of OOM events triggered by the container,0,container,mem_oom_events,
container.memory.page_faults,count,,,,Total number of page faults incurred,0,container,pgfault,
container.memory.rss,gauge,,byte,,The container RSS usage,0,container,mem_rss,
container.memory.rss,gauge,,byte,,The 'anon' memory used by the container,0,container,mem_rss,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can perhaps improve more with the Kernel description:

Amount of memory used in anonymous mappings such as brk(), sbrk(), and mmap(MAP_ANONYMOUS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant to include more specific linux concepts as this appears to be cross-platform, and I don't know what this reports on windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a Linux-only metric.

container.memory.soft_limit,gauge,,byte,,The container memory soft limit,0,container,mem_soft_limit,
container.memory.swap,gauge,,byte,,The container swap usage,0,container,mem_swap,
container.memory.usage,gauge,,byte,,The container total memory usage,0,container,mem_usage,
Expand Down
Loading