Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Module interaction and state fixes #214

Merged
merged 13 commits into from
Jan 2, 2024
Merged

Module interaction and state fixes #214

merged 13 commits into from
Jan 2, 2024

Conversation

Gumball2415
Copy link
Member

@Gumball2415 Gumball2415 commented May 16, 2023

This pull request aims to fix module state and interaction bugs.

This pull request iterates upon PR #195.

Changes in this PR:

@nyanpasu64
Copy link
Collaborator

this can't be right? i saw a frame -1 causing a crash at runtime.

i have determined that famitracker has crashed trying to restore channel state as of frame (unsigned)-1 = 0xffffffff, on channel 4 (presumably it would crash on all channels and 4 is the first one restored)

famitracker wine crash.pdf

try a release ASAN build with the assert removed, if it crashes, then this PR is wrong.

@Gumball2415
Copy link
Member Author

it does not crash on ASAN release with the asserts removed

@Gumball2415 Gumball2415 marked this pull request as ready for review June 5, 2023 14:58
@Gumball2415 Gumball2415 marked this pull request as draft August 1, 2023 13:18
@Gumball2415 Gumball2415 linked an issue Nov 19, 2023 that may be closed by this pull request
This prevents modules to be saved with version 0x450 but without the
Dn-FT specific file header, causing the program to interpret it as
FT 050b modules instead.
@Gumball2415 Gumball2415 marked this pull request as ready for review December 29, 2023 12:23
@Gumball2415 Gumball2415 merged commit 3d77513 into main Jan 2, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment