-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Module interaction and state fixes #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can't be right? i saw a frame -1 causing a crash at runtime.
try a release ASAN build with the assert removed, if it crashes, then this PR is wrong. |
it does not crash on ASAN release with the asserts removed |
Gumball2415
force-pushed
the
fix-module
branch
from
November 28, 2023 17:58
c84db6d
to
030e85d
Compare
Gumball2415
force-pushed
the
fix-module
branch
from
December 19, 2023 12:40
00a7eb8
to
6be25b0
Compare
This prevents modules to be saved with version 0x450 but without the Dn-FT specific file header, causing the program to interpret it as FT 050b modules instead.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix module state and interaction bugs.
This pull request iterates upon PR #195.
Changes in this PR: