Update SA1404 to not crash when attribute uses a namespace alias #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornhellander
force-pushed
the
feature/sa1404-global-3829
branch
from
3fc7fed to
1f7ac37
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3830 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 925 925
Lines 110040 110057 +17
Branches 3302 3303 +1
=======================================
+ Hits 107236 107257 +21
+ Misses 1839 1836 -3
+ Partials 965 964 -1 |
|
Ready for review |
sharwell
approved these changes
Apr 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3829