Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update SA1404 to not crash when attribute uses a namespace alias #3830

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update SA1404 to not crash when attribute uses a namespace alias #3830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions StyleCop.Analyzers/StyleCop.Analyzers.Test/MaintainabilityRules/SA1404UnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,5 +426,23 @@ public void Bar()

await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
}

[Theory]
[InlineData("global::System.Obsolete")]
[InlineData("global::My")]
[WorkItem(3829, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3829")]
public async Task TestGlobalOtherAttributeAsync(string name)
{
var testCode = $@"public class MyAttribute : System.Attribute
{{
}}

[{name}]
public class Foo
{{
}}";

await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
}
}
}
11 changes: 9 additions & 2 deletions ...eCop.Analyzers/MaintainabilityRules/SA1404CodeAnalysisSuppressionMustHaveJustification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,15 @@ public void HandleAttributeNode(SyntaxNodeAnalysisContext context)
{
if (!(attribute.Name is SimpleNameSyntax simpleNameSyntax))
{
QualifiedNameSyntax qualifiedNameSyntax = attribute.Name as QualifiedNameSyntax;
simpleNameSyntax = qualifiedNameSyntax.Right;
if (attribute.Name is AliasQualifiedNameSyntax aliasQualifiedNameSyntax)
{
simpleNameSyntax = aliasQualifiedNameSyntax.Name;
}
else
{
QualifiedNameSyntax qualifiedNameSyntax = attribute.Name as QualifiedNameSyntax;
simpleNameSyntax = qualifiedNameSyntax.Right;
}
}

if (simpleNameSyntax.Identifier.ValueText != nameof(SuppressMessageAttribute)
Expand Down