Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ui): disable dates after today in DateRange #1099

Merged
merged 12 commits into from
Jan 31, 2025
Merged

fix(ui): disable dates after today in DateRange #1099

merged 12 commits into from
Jan 31, 2025

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Jan 31, 2025

💬 Description / Notes

There was some old functionality where the last date you could select in the DateRange filter could be in the future. Changed it to only allow up to today.

🛠 Changes

  • set the disabled dates in the DateRange to be after the end of the day today
  • change the getBusinessDayTimestamp function back to returning midnight of the current business day
  • updated the tests for getBusinessDayTimestamp to expect midnight instead of 11:59:59.999

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.7% 4186 / 4773
🔵 Statements 87.13% 4557 / 5230
🔵 Functions 78.99% 1222 / 1547
🔵 Branches 72.21% 2056 / 2847
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/packages/shared-utils/seatool-date-helper.ts 93.33% 72.72% 50% 100% 27
react-app/src/components/Opensearch/main/Filtering/Drawer/Filterable/DateRange.tsx 100% 90.47% 100% 100%
Generated in workflow #1852 for commit 957b60e by the Vitest Coverage Report Action

@thetif thetif temporarily deployed to date-filter-max January 31, 2025 17:11 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to date-filter-max January 31, 2025 17:11 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to date-filter-max-app January 31, 2025 17:11 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to date-filter-max-kibana January 31, 2025 17:11 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to date-filter-max January 31, 2025 17:11 — with GitHub Actions Inactive
@thetif thetif requested a review from 13bfrancis January 31, 2025 17:20
@thetif thetif temporarily deployed to date-filter-max January 31, 2025 17:30 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to date-filter-max January 31, 2025 17:30 — with GitHub Actions Inactive
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.120 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rmuntaqim pushed a commit that referenced this pull request Feb 4, 2025
13bfrancis added a commit that referenced this pull request Feb 13, 2025
* testing filter adjust

* testing filter

* debugging duplicates

* chore: remove `Intake Needed` from Filters (#1093)

* fix(ui): disable dates after today in DateRange (#1099)

* fixed issue with date-range filter

* feat(test) feature package snapshots (#1078)

* feat(test) feature package snapshots

* linter issue

* update for unit test

* Updates to test

* update search.test

* admin page test

* update import directory for renderwithqueryclient

* hopefully fix date issue on test

* set it as utc date in test so it works in github

* cleanup

* package status snapshot

* change id to prop for pulling in data

* Fixing some test

* linter corrections

* fix date issue

* fix(ui): Fix chip pdf links issue on FAQ page (#1080)

* feat(test) attachment url (#1104)

* fix: update email preview command (#1108)

* fix(ui): DateRange fix (#1107)

* resolved issue with DateRange showing the wrong dates for today
* resolved failing DateRange test
* added new GitHub Action to push code coverage to code climate and upload it as an artifact
* updated the pr-coverage-annocation action to download the main coverage report and compare it to the branch coverage report
* removed code coverage from the deploy test action

* fix(all-state-emails): Add logic to include all state emails in templates (#1106)

* add logging

* Update processEmails.ts

* Update processEmails.ts

* Update index.tsx

* Update index.tsx

* Update processEmails.ts

* Update processEmails.ts

* feat(ui): update new submission Medicaid SPA card language (#1100)

* testing values

* testing

* testing values

* testing select filter

* testing filter adjust

* testing filter

* testing filter

* updating initial filter

* updating the filter

* updating filter

* clearing console-log

* updating filter test

* cleaning up the drawer filter

* dup filter remove

* reverting back to main

---------

Co-authored-by: asharonbaltazar <58940073+asharonbaltazar@users.noreply.github.com>
Co-authored-by: Tiffany Forkner <thetif@gmail.com>
Co-authored-by: Thomas Walker <thomas.e.walker88@gmail.com>
Co-authored-by: Ty Bolt <tybolt@gmail.com>
Co-authored-by: James Dinh <jdinh8124@gmail.com>
Co-authored-by: 13bfrancis <40218571+13bfrancis@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants